search

storybookjs / eslint-plugin-storybook

🎗Official ESLint plugin for Storybook
MIT License
238 stars 42 forks source link

Update typescript-eslint to v6 #138

Open MaximeGrimler opened 11 months ago

MaximeGrimler commented 11 months ago

Is your feature request related to a problem? Please describe. Would it be possible to update the dependencies of typescript-eslint from v5 to v6 v6 had been announced at beginning of July : https://typescript-eslint.io/blog/announcing-typescript-eslint-v6/

Describe the solution you'd like Update the dependency package version from v5 to v6

Thanks ! :smile:

jalovatt commented 7 months ago

Bumping this, as it can cause problems if you try to use the current version with Typescript 5.2.

@typescript-eslint v5 uses tsutils, which uses syntax that was deprecated in Typescript 5.0 and removed in 5.2. tsutils is dead, and @typescript-eslint have moved off of it for their v6.

Obvously users should be on top of making sure they update dependencies safely, things are still working, etc, but it took a good hour to track down why my lint command suddenly fell apart after updating TS this morning.

Updating this package to use @typescript-eslint v6 would be ideal, but if nothing else you folks may want to add a warning that this library is expressly not compatible with Typescript >= 5.2 until that issue is resolved.

lesha1201 commented 6 months ago

@yannbf I can work on this and open a PR but I'm not sure if the project is actively maintained and what plans it has. Should I work on this?