extend story-exports rule to support export lists, fixes #57

[stephenhmarsh]

Issue: #57

What Changed

Fixed a bug where the story-exports rule gave a false negative because it did not check for exports from an export list, only from inline export declarations.

Checklist

Check the ones applicable to your change:

• [ ] Ran yarn update-all
• [x] Tests are updated
• [ ] Documentation is updated

Change Type

Indicate the type of change your pull request is:

• [ ] maintenance
• [ ] documentation
• [x] patch
• [ ] minor
• [ ] major

[yannbf]

Hey @stephenhmarsh thanks a lot for your contribution! I moved the logic into a utility function so that it can be reused by other rules. I also changed the check from local to exported, although I'm not sure which would matter the most 🤔 @shilman thoughts?

const primary = {} <-- local name

export { primary } <-- exported name

[stephenhmarsh]

Welcome! Yeah I just went with local initially because I wasn't sure either. Like, if someone does export { story1 as name1 }, how does that change things like checks against excludeStories, etc.?

[yannbf]

Welcome! Yeah I just went with local initially because I wasn't sure either. Like, if someone does export { story1 as name1 }, how does that change things like checks against excludeStories, etc.?

the checks will be done with what's being exported from the package, therefore I believe we should go with the exported check!

[yannbf]

Thanks a lot for your contribution @stephenhmarsh !! Superb stuff 👌

[github-actions[bot]]

:rocket: PR was released in v0.5.3 :rocket:

[stephenhmarsh]

Awesome thanks @yannbf 👍