search

storybookjs / frontpage

🌐 The website for storybook.js.org
https://storybook.js.org
MIT License
214 stars 120 forks source link

Remove skip on v7 tests for CodeSnippets #528

Closed joaonunomota closed 1 year ago

joaonunomota commented 1 year ago

If I understood correctly the comments left by @kylegach, tests were meant to not be skipped once v7 was tagged as latest.

Tests all passed when I checked.

netlify[bot] commented 1 year ago

Deploy Preview for storybook-frontpage ready!

Name Link
Latest commit 9893b669ec5e48e27f538c58e5fed719f13d9225
Latest deploy log https://app.netlify.com/sites/storybook-frontpage/deploys/6453ecd34ca3f20008ca4c38
Deploy Preview https://deploy-preview-528--storybook-frontpage.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

kylegach commented 1 year ago

Thanks for catching our oversight, @joaonunomota!

I just rebased onto the latest main, for two reasons:

  1. It's always best to merge a fully-updated branch
  2. The CI checks were failing because of your forked branch and lack of authorization. I'm hoping my involvement might (somehow? 🤞) get it past that.
kylegach commented 1 year ago

Yeah, that didn't work. 😅

I just replicated the steps locally (yarn build && yarn test) and I'm confident this change is OK, so I'm merging.

Thanks again!