search

storybookjs / icons

Library of icons used in apps and marketing sites
MIT License
9 stars 3 forks source link

Move all deps to dev deps #14

Closed TrySound closed 1 year ago

TrySound commented 1 year ago

Ref https://github.com/storybookjs/storybook/pull/23635#issuecomment-1664341573

Looks like all dependencies are build only and should not bloat user installation with deprecated and vulnerable packages.

ndelangen commented 1 year ago

@cdedreuille I think this PR needs your hands-on. It looks to me there are quite a few more dependencies that should actually be devDependencies. Not just the ones changed in this PR. Could you have a look at moving everything that should be a devDependency?

TrySound commented 1 year ago

They are already in dev deps

TrySound commented 1 year ago

I removed dependencies section completely

cdedreuille commented 1 year ago

Awesome. Thanks for taking the time to solve this @TrySound. We should not have any dependency indeed.

cdedreuille commented 1 year ago

@TrySound I just took the shot at adding a new icon.