search

storybookjs / mdx2-csf

MDX to CSF compiler using MDXv2
MIT License
14 stars 9 forks source link

Take remarkPlugins into account for this loader #12

Closed quantizor closed 1 year ago

quantizor commented 2 years ago

Storybook composes multiple remark plugins that need to be forwarded to the compiler. This does not completely fix #11 but at least makes sure when the options make it across to the loader properly they will be applied to the compiled MDX.

quantizor commented 2 years ago

@shilman hi! Any chance we could get this merged soon?

kylegach commented 2 years ago

Hi, Evan. Sorry for the delay here. We'll take a look soon. Thank you for the contribution!

kylegach commented 2 years ago

@shilman — We looked at this in triage. While the change is straightforward and looks great on the surface, we suspect there may be nuances here that need QA'd and possibly addressed.

ivlev-ye commented 2 years ago

@shilman Hi! Any chance this will be merged soon?

tienne commented 1 year ago

Is there any progress on this?

shilman commented 1 year ago

I've taken a different approach on this here: https://github.com/storybookjs/mdx2-csf/pull/27

It's not drop-in compatible with the MDX1.x API but I think it's a more future-proof approach for SB7.0, which is using this library by default now.

Feedback welcome. This PR is released in a prerelease if anybody wants to try it.

JReinhold commented 1 year ago

Closing as superseded by #27 which implements the same functionality and more.