search

storybookjs / native

📱 Storybook for Native: iOS, Android, Flutter
MIT License
184 stars 29 forks source link

Change default iOS device to iPhone 12 #70

Closed daisyduong-acc closed 2 years ago

daisyduong-acc commented 2 years ago

Building off of this PR: https://github.com/storybookjs/native/pull/69, I'd like to set the default iOS emulator device to the iPhone 12 because my storybook iOS components are compatible with iOS 14+. The iPhone 12's are the only devices on the device list that default to iOS 14.

Since there isn't really a way to switch emulator OS versions right now, having the emulator default to an iPhone 12 would be much more convenient to users viewing mobile components that support the latest iOS versions (instead of having to instruct them to switch devices using the device menu each time they view a new component).

📦 Published PR as canary version: 2.2.4-canary.70.754.0
:sparkles: Test out this PR locally via: ```bash npm install @storybook/native-android-material-deep-link-example@2.2.4-canary.70.754.0 npm install @storybook/native-controls-example@2.2.4-canary.70.754.0 npm install @storybook/native-cross-platform-example@2.2.4-canary.70.754.0 npm install @storybook/native-flutter-example@2.2.4-canary.70.754.0 npm install @storybook/native-ios-example-deep-link@2.2.4-canary.70.754.0 npm install @storybook/native-addon@2.2.4-canary.70.754.0 npm install @storybook/native-controllers@2.2.4-canary.70.754.0 npm install @storybook/deep-link-logger@2.2.4-canary.70.754.0 npm install @storybook/native-dev-middleware@2.2.4-canary.70.754.0 npm install @storybook/native-devices@2.2.4-canary.70.754.0 npm install @storybook/native-components@2.2.4-canary.70.754.0 npm install @storybook/native@2.2.4-canary.70.754.0 npm install @storybook/native-types@2.2.4-canary.70.754.0 # or yarn add @storybook/native-android-material-deep-link-example@2.2.4-canary.70.754.0 yarn add @storybook/native-controls-example@2.2.4-canary.70.754.0 yarn add @storybook/native-cross-platform-example@2.2.4-canary.70.754.0 yarn add @storybook/native-flutter-example@2.2.4-canary.70.754.0 yarn add @storybook/native-ios-example-deep-link@2.2.4-canary.70.754.0 yarn add @storybook/native-addon@2.2.4-canary.70.754.0 yarn add @storybook/native-controllers@2.2.4-canary.70.754.0 yarn add @storybook/deep-link-logger@2.2.4-canary.70.754.0 yarn add @storybook/native-dev-middleware@2.2.4-canary.70.754.0 yarn add @storybook/native-devices@2.2.4-canary.70.754.0 yarn add @storybook/native-components@2.2.4-canary.70.754.0 yarn add @storybook/native@2.2.4-canary.70.754.0 yarn add @storybook/native-types@2.2.4-canary.70.754.0 ```
amalik2 commented 2 years ago

Thanks for the contribution!

sumwatshade commented 2 years ago

:rocket: PR was released in v2.2.4 :rocket: