search

storybookjs / react-native

📓 Storybook for React Native!
https://storybook.js.org
MIT License
1.07k stars 155 forks source link

Fix missing icons on react-native < 0.71 #455

Closed stevoland closed 1 year ago

stevoland commented 1 year ago

Issue:

width and height were only introduced as props on Image in react-native 0.71 (see eg docs for 0.70). Versions below this don't display the icons.

What I did

Moved the dimensions to properties of the source prop

How to test

Check the expo-example visually then struggle to downgrade the react-native version (I didn't manage it!)

dannyhw commented 1 year ago

@stevoland thanks!

dannyhw commented 1 year ago

@stevoland can you check version 6.5.2

stevoland commented 1 year ago

@dannyhw 6.5.2 icons fixed in my RN 0.69 project, thanks!