Closed tlow92 closed 4 weeks ago
thanks for getting this underway! I think we got a good solution here. I'm going to merge and start working toward a 8.4 pre-release with multiple changes in it
I looked at the code the hack I did with export = withStorybook
is not needed if you converted to typescript instead just export function withStorybook
in an earlier line.
The hack was needed because of the d.ts nature which no longer applies.
Proposal to fix https://github.com/storybookjs/react-native/issues/630
withStorybook
is imported like thisrequire('@storybook/react-native/metro/withStorybook');
I think ideallywithStorybook
would live in src like all other files and be transpiled todist
, but that would be a breaking change.dist
and put barrel files inmetro
folder so that it is not a breaking change, but that created problems with tsup because apparently it can not handle barrel.d.ts
files and always emits an empty.d.ts
.tsup
cmd to specify a differentoutDir
(metro
folder)