storybookjs / react-native

📓 Storybook for React Native!
https://storybook.js.org
MIT License
1.08k stars 156 forks source link

fix: add missing devDependency(ts-dedent) #638

Closed duguyihou closed 3 weeks ago

duguyihou commented 4 weeks ago

Issue:

What I did

add ts-dedent to devDependency

How to test

ts-dedent is not in the devDependency list but it is required in StoryHash.ts

storybookdemo

Please explain how to test your changes and consider the following questions

dannyhw commented 3 weeks ago

weird that I never saw this before but I guess it should just be a regular dependency not dev dependency right?

duguyihou commented 3 weeks ago

In storybookJS project, it is in devDependency as well. image

dannyhw commented 3 weeks ago

hmm well its probably just prebundling it thats why, anyway I think this is fine to merge

dannyhw commented 3 weeks ago

Thanks for the contribution 👍