storybookjs / storybook

Storybook is the industry standard workshop for building, documenting, and testing UI components in isolation
https://storybook.js.org
MIT License
84.22k stars 9.26k forks source link

Invalid default values for VueJS components in props table #11582

Closed jonhuteau closed 4 years ago

jonhuteau commented 4 years ago

Describe the bug I'm upgrading to v6.0.0-rc.8 and defaults values in props tables are empty. If I revert changes made at https://github.com/storybookjs/storybook/pull/11534/files#diff-ac92839dce97cc5e5fdcc8587102c691, I can see default values.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://next--storybookjs.netlify.app/vue-kitchen-sink/?path=/docs/button--rounded
  2. Look at button's default values
  3. controls should be OK but default col contains empty string (for color prop for example)

Expected behavior Default values should be present in default column of props table

Screenshots

image

System:

$ npx -p @storybook/cli@next sb info

Environment Info:

  System:
    OS: Linux 4.15 Ubuntu 18.04.4 LTS (Bionic Beaver)
    CPU: (8) x64 Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz
  Binaries:
    Node: 12.18.2 - /usr/bin/node
    npm: 6.14.5 - /usr/bin/npm
  Browsers:
    Chrome: 83.0.4103.116
    Firefox: 78.0.2
  npmPackages:
    @storybook/addon-a11y: ^6.0.0-rc.8 => 6.0.0-rc.8 
    @storybook/addon-controls: ^6.0.0-rc.8 => 6.0.0-rc.8 
    @storybook/addon-docs: ^6.0.0-rc.8 => 6.0.0-rc.8 
    @storybook/addon-jest: ^6.0.0-rc.8 => 6.0.0-rc.8 
    @storybook/addon-viewport: ^6.0.0-rc.8 => 6.0.0-rc.8 
    @storybook/addons: ^6.0.0-rc.8 => 6.0.0-rc.8 
    @storybook/vue: ^6.0.0-rc.8 => 6.0.0-rc.8 
shilman commented 4 years ago

Thanks @jonhuteau -- will get it sorted!

shilman commented 4 years ago

Egads!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.0.0-rc.11 containing PR #11603 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.