search

storybookjs / storybook

Storybook is the industry standard workshop for building, documenting, and testing UI components in isolation
https://storybook.js.org
MIT License
84.22k stars 9.26k forks source link

storybook --host option not changing the network host #12865

Closed lexsoft00 closed 3 years ago

lexsoft00 commented 3 years ago

Describe the bug Storybook --host attribute it changes localhost where it should change network host.

start-storybook -h 192.168.89.89 -p 9009
Local:            http://192.168.89.89:9009
On your network:  http://10.0.2.15:9009

The expected result should be like the one bellow

Local:            http://localhost::9009/ 
On your network:  http://192.168.89.89:9009

To Reproduce Steps to reproduce the behavior:

{
  "name": "bootstrap_storybook",
  "description": "Drupal theme with storybookJS integrated with a lot of extra goodies",
  "private": true,
  "scripts": {
    "postinstall": "find node_modules/ -name '*.info' -type f -delete",
    "storybook": "start-storybook -h 192.168.89.89 -p 9009"
  },
  "devDependencies": {
    "@babel/cli": "^7.7.7",
    "@babel/core": "^7.7.2",
    "@storybook/addon-a11y": "^6.0.22",
    "@storybook/addon-actions": "^6.0.22",
    "@storybook/addon-backgrounds": "^6.0.22",
    "@storybook/addon-docs": "^6.0.22",
    "@storybook/addon-knobs": "^6.0.22",
    "@storybook/addon-links": "^6.0.22",
    "@storybook/addon-notes": "^5.3.21",
    "@storybook/addon-storysource": "^6.0.22",
    "@storybook/addon-viewport": "^6.0.22",
    "@storybook/html": "^6.0.22",
    "babel-loader": "^8.0.6",
    "babel-plugin-drupal-behaviors": "^0.1.1",
    "bootstrap": "4.3.1",
    "browser-sync": "^2.26.12",
    "browser-sync-webpack-plugin": "2.2.2",
    "cross-env": "^5.2",
    "css-loader": "^3.4.0",
    "drupal-attribute": "^1.0.2",
    "jquery": "^3.5.1",
    "laravel-mix": "^5.0.5",
    "laravel-mix-copy-watched": "^2.2.2",
    "mini-css-extract-plugin": "^0.11.0",
    "acorn": "^6.0.0",
    "node-sass": "^4.14.1",
    "npm-run-all": "^4.1.5",
    "popper.js": "^1.16.1",
    "sass": "^1.25",
    "sass-loader": "^7.3.1",
    "twig": "~1.10.5",
    "twig-drupal-filters": "^2.0.0",
    "twig-loader": "^0.5.1",
    "vue-template-compiler": "^2.6.11",
    "webpack": "^4.41.4",
    "webpack-cli": "^3.3.10",
    "webpack-fix-style-only-entries": "^0.4.0",
    "critical": "^2.0.1",
    "laravel-mix-criticalcss": "^1.0.1",
    "html-critical-webpack-plugin": "^2.1.0",
    "resolve-url-loader": "^3.1.0"
  }
}

Expected behavior The expected result should be like the one bellow

Local:            http://localhost::9009/ 
On your network:  http://192.168.89.89:9009

System

Environment Info:

  System:
    OS: Linux 4.15 Ubuntu 18.04.4 LTS (Bionic Beaver)
    CPU: (4) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
  Binaries:
    Node: 10.22.1 - /usr/bin/node
    npm: 6.14.6 - /usr/bin/npm
  Browsers:
    Chrome: 85.0.4183.121
  npmPackages:
    @storybook/addon-a11y: ^6.0.22 => 6.0.26
    @storybook/addon-actions: ^6.0.22 => 6.0.26
    @storybook/addon-backgrounds: ^6.0.22 => 6.0.26
    @storybook/addon-docs: ^6.0.22 => 6.0.26
    @storybook/addon-knobs: ^6.0.22 => 6.0.26
    @storybook/addon-links: ^6.0.22 => 6.0.26
    @storybook/addon-notes: ^5.3.21 => 5.3.21
    @storybook/addon-storysource: ^6.0.22 => 6.0.26
    @storybook/addon-viewport: ^6.0.22 => 6.0.26
    @storybook/html: ^6.0.22 => 6.0.26
Diacron commented 3 years ago

Hi is this issue open to new comers?

yannbf commented 3 years ago

Hey @Diacron if you'd like to take a look at it, your help is very welcome!

shilman commented 3 years ago

Gadzooks!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.2.0-alpha.10 containing PR #13521 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease
shilman commented 3 years ago

Yippee!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.1.14 containing PR #13521 that references this issue. Upgrade today to the @latest NPM tag to try it out!

npx sb upgrade