storybookjs / storybook

Storybook is the industry standard workshop for building, documenting, and testing UI components in isolation
https://storybook.js.org
MIT License
84.6k stars 9.31k forks source link

An in-range update of prettier is breaking the build 🚨 #1475

Closed greenkeeper[bot] closed 7 years ago

greenkeeper[bot] commented 7 years ago

Version 1.5.3 of prettier just got published.

Branch Build failing 🚨
Dependency prettier
Current Version 1.5.2
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As prettier is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this :muscle:

Status Details - ❌ **continuous-integration/codeship** Build in progress [Details](https://app.codeship.com/projects/225072/builds/26839600) - ❌ **continuous-integration/travis-ci/push** The Travis CI build is in progress [Details](https://travis-ci.org/storybooks/storybook/builds/253886594?utm_source=github_status&utm_medium=notification) - ✅ **Better Code Hub** ✅ Better Code Hub approves this code [Details](https://bettercodehub.com/results/storybooks/storybook/1c7ada7661fa45a8e78822fa56b7f835feaa7bdd) - ❌ **bitHound - Dependencies** 1 failing dependency. [Details](https://www.bithound.io/github/storybooks/storybook/1c7ada7661fa45a8e78822fa56b7f835feaa7bdd/dependencies/npm#filter-failing-dep) - ✅ **bitHound - Code** No failing files. [Details](https://www.bithound.io/github/storybooks/storybook/1c7ada7661fa45a8e78822fa56b7f835feaa7bdd/files?status=passing)

Not sure how things should work exactly? There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 7 years ago

After pinning to 1.5.2 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

danielduan commented 7 years ago

Convinced this doesn't actually break anything since prettier is only run during development.