search

storybookjs / storybook

Storybook is a frontend workshop for building UI components and pages in isolation. Made for UI development, testing, and documentation.
https://storybook.js.org
MIT License
83.34k stars 9.11k forks source link

Resolve issue with smoke-testing `cra/default-ts` #19351

Open tmeasday opened 1 year ago

tmeasday commented 1 year ago

Describe the bug The cra/default-ts smoke test task works but then regularly times out (maybe 80% of the time). The execa() call just never returns (see https://github.com/storybookjs/storybook/pull/19306 for investigations).

We have no idea why but it happens only for that template, we can speculate that maybe it uses more memory or something.

Possible fixes

First off we want to just update execa (and maybe node also) and see if it goes away.

Otherwise, we might have to try and create a reproduction, get it going on CI and then see if we can debug into execa to see what's happening (doesn't sound fun). So let's do the former and hope for luck 🤞

Once it is fixed we should revert this commit: 17ddcb71ba

shilman commented 1 year ago

Good golly!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-alpha.35 containing PR #19352 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

shilman commented 1 year ago

Yee-haw!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-alpha.38 containing PR #19466 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.