search

storybookjs / storybook

Storybook is the industry standard workshop for building, documenting, and testing UI components in isolation
https://storybook.js.org
MIT License
84.14k stars 9.25k forks source link

[Bug]: 6.5->7 migration failed for CRA reproduction #20040

Closed tmeasday closed 1 year ago

tmeasday commented 1 year ago

Describe the bug

I ran npx sb@next upgrade --prerelease on this reproduction from https://github.com/storybookjs/storybook/issues/18258: https://github.com/reinertisa/my-example-reproduction

The migration did not:

  1. Upgrade to webpack5
  2. change the framework field
  3. Add the CRA preset (not sure why it wasn't there already).

To Reproduce

No response

System

No response

Additional context

No response

yannbf commented 1 year ago

Hey @tmeasday I ran the same command in the repro and I had a successful migration (related to our current fixes):

The framework field already existed in the repro, and it got changed to the correct package too:

image

The preset didn't get added because we do not have an automigration for that.

tmeasday commented 1 year ago

That looks pretty good @yannbf. I'm not sure why it didn't happen to me, but maybe we fixed something in the meantime. I think we can close this.