[Bug]: Measure tool stays active when switching to Docs, causing it to measure the Docs page.

storybookjs / storybook

Storybook is the industry standard workshop for building, documenting, and testing UI components in isolation

https://storybook.js.org

MIT License

83.99k stars 9.23k forks source link

[Bug]: Measure tool stays active when switching to Docs, causing it to measure the Docs page. #21327

Closed yannbf closed 1 year ago

yannbf commented 1 year ago

Describe the bug

Reported by @kbrandwijk (Thank you!)

The measure tool stays active when switching to Docs, causing it to measure the Docs page.

⚠️ Additionally, the Measure addon functionality, even though there is no button to enable it in docs mode, can be enabled via keyboard shortcuts. When it's enabled, it can't be disabled via keyboard shortcuts anymore.

To Reproduce

Run Storybook 7 with addon-essentials
Open a story, toggle measure on (press M or the addon icon)
Switch to docs

System

No response

Additional context

No response

Dev79844 commented 1 year ago

Hey I would like to work on this issue. Can you assign it to me?

shilman commented 1 year ago

Good golly!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.1.0-alpha.15 containing PR #21602 that references this issue. Upgrade today to the @future NPM tag to try it out!

npx sb@next upgrade --tag future

shilman commented 1 year ago

Great Caesar's ghost!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.11 containing PR #21602 that references this issue. Upgrade today to the @latest NPM tag to try it out!

npx sb@latest upgrade