[Bug]: `CTRL + K` keyboard shortcut conflicts with windows browser search

storybookjs / storybook

Storybook is the industry standard workshop for building, documenting, and testing UI components in isolation

https://storybook.js.org

MIT License

84.23k stars 9.26k forks source link

[Bug]: `CTRL + K` keyboard shortcut conflicts with windows browser search #25815

Open vanessayuenn opened 8 months ago

vanessayuenn commented 8 months ago

Describe the bug

Project: Bitwarden Version: 8.0.0-alpha.14 Bug/feedback: Ctrl + K triggers the browser search instead of Storybook's search

When a Story is focused and CTRL + K combination is pressed, the browsers search bar is focused. As discussed with @cdedreuille, we might revert the keyboard mapping and stick with the old / key instead

Reported in https://github.com/storybookjs/storybook/discussions/25688?sort=new#discussioncomment-8245899

To Reproduce

No response

System

No response

Additional context

No response

fdendorfer commented 5 months ago

Why not make it both, or togglable, or customizable? Ctrl+K seems to be pretty widely adopted for on page searches in other documentation pages.

Onra commented 3 months ago

Hi there,

I wanted to add some additional information regarding this issue.

Ctrl + K seems to work fine and does not trigger the browser's search bar if the focus is already in the left menu.
However, Ctrl + K triggers the browser's search if the focus is on the story on the right.
On Storybook's official documentation, Ctrl + K works fine and the browser's search bar is not triggered. Is there something we could do to improve this while still keeping Ctrl + K as a shortcut? I agree it is quite a standard nowadays.

Thank you for looking into this!

valentinpalkovic commented 3 months ago

@cdedreuille I think you wanted to take another look at this.