greptile-apps[bot]
commented
3 weeks ago Disclaimer This information might be inaccurate, due to it being generated automatically
To resolve the issue of the callback being called multiple times in webpack-loader.ts, modify the loader function to ensure the callback is only called once. Specifically, move the callback call outside of the try block and handle errors separately. Here is the updated code snippet:
async function loader(this: LoaderContext, content: string, map: any) {
const callback = this.async();
const options = this.getOptions();
const id = this.resourcePath;
const sourceCode = await fs.readFile(id, 'utf-8');
try {
const makeTitle = (userTitle: string) => userTitle || 'default';
const csf = loadCsf(content, { makeTitle }).parse();
const csfSource = loadCsf(sourceCode, { makeTitle }).parse();
enrichCsf(csf, csfSource, options);
const formattedCsf = formatCsf(csf, { sourceMaps: true, inputSourceMap: map }, content);
if (typeof formattedCsf === 'string') {
callback(null, formattedCsf, map);
} else {
callback(null, formattedCsf.code, formattedCsf.map);
}
} catch (err: any) {
// This can be called on legacy storiesOf files, so just ignore
// those errors. But warn about other errors.
if (!err.message?.startsWith('CSF:')) {
console.warn(err.message);
}
callback(null, content, map);
}
}This ensures the callback is only called once, preventing the callback(): The callback was already called error.
References
/code/lib/csf-plugin/src/webpack-loader.ts /code/lib/csf-plugin
stof
TylerNRobertson
yannbf
shilman
valentinpalkovic
ckifer
Describe the bug
Our storybook setup was working fine with Storybook 8.1. However, when trying to upgrade to 8.2, I'm getting this report:
The error location in
@storybook/csf-plugin/dist/webpack-loader.jscorresponds to the call in https://github.com/storybookjs/storybook/blob/v8.2.2/code/lib/csf-plugin/src/webpack-loader.ts#L36 Apparentlycallbackis caused multiple time which is forbidden byloader-runner. Looking at the code quickly, I suspect this might happen when an error is thrown during the execution of the callback itself (for a successful processing) as they are inside thetryblock: https://github.com/storybookjs/storybook/blob/v8.2.2/code/lib/csf-plugin/src/webpack-loader.ts#L25-L29Reproduction link
none yet
Reproduction steps
No response
System
Additional context
No response