storybookjs / storybook

Storybook is the industry standard workshop for building, documenting, and testing UI components in isolation
https://storybook.js.org
MIT License
84.81k stars 9.34k forks source link

[Bug]: @storybook/angular Zone mismatch. Package has "zone.js": "^0.14.2" peer dependencies "zone.js": ">= 0.11.1 < 1.0.0" #29065

Open bizappzone opened 2 months ago

bizappzone commented 2 months ago

Describe the bug

Looking at code > frameworks > angular there is a mismatch for zone

See below..

"zone.js": "^0.14.2"

}, "peerDependencies": { "@angular-devkit/architect": ">=0.1500.0 < 0.1900.0", "@angular-devkit/build-angular": ">=15.0.0 < 19.0.0", "@angular-devkit/core": ">=15.0.0 < 19.0.0", "@angular/cli": ">=15.0.0 < 19.0.0", "@angular/common": ">=15.0.0 < 19.0.0", "@angular/compiler": ">=15.0.0 < 19.0.0", "@angular/compiler-cli": ">=15.0.0 < 19.0.0", "@angular/core": ">=15.0.0 < 19.0.0", "@angular/forms": ">=15.0.0 < 19.0.0", "@angular/platform-browser": ">=15.0.0 < 19.0.0", "@angular/platform-browser-dynamic": ">=15.0.0 < 19.0.0", "rxjs": "^6.0.0 || ^7.4.0", "storybook": "workspace:^", "typescript": "^4.0.0 || ^5.0.0", "zone.js": ">= 0.11.1 < 1.0.0" },

Reproduction link

https://github.com/storybookjs/storybook/blob/next/code/frameworks/angular/package.json

Reproduction steps

Looking at code > frameworks > angular there is a mismatch for zone in package.json

ERR! zone.js@"0.14.3" from the root project npm ERR! peer zone.js@">= 0.11.1 < 1.0.0" from @storybook/angular@8.2.9

System

info

Additional context

No response

valentinpalkovic commented 2 months ago

@bizappzone The peerDependency version range defines the allowed range of zone.js. The devDependency definition of zone.js is the one we use internally. It shouldn't affect you as a user. Can you please provide a proper reproduction? I don't know how the error

"ERR! zone.js@"0.14.3" from the root project
npm ERR! peer zone.js@">= 0.11.1 < 1.0.0" from @storybook/angular@8.2.9"

is reproduced. I guess you are wrongly using npm in our monorepo, although you would have to use yarn instead.