Closed shilman closed 4 days ago
CI is running/has finished running commands for commit d5ba8e56e787a3e860e053fc076fe6b818376ab9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
๐ See all runs for this CI Pipeline Execution
Sent with ๐ from NxCloud.
Closes #28269
What I did
Fix HMR performance issue by downgrading the react-docgen-typescript Vite plugin
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Upgrade repro in #28269 to canary (have not tested)
๐ฆ Canary release
This pull request has been released as version
0.0.0-pr-29184-sha-d5ba8e56
. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-29184-sha-d5ba8e56 sandbox
or in an existing project withnpx storybook@0.0.0-pr-29184-sha-d5ba8e56 upgrade
.More information
| | | | --- | --- | | **Published version** | [`0.0.0-pr-29184-sha-d5ba8e56`](https://npmjs.com/package/storybook/v/0.0.0-pr-29184-sha-d5ba8e56) | | **Triggered by** | @shilman | | **Repository** | [storybookjs/storybook](https://github.com/storybookjs/storybook) | | **Branch** | [`shilman/28269-downgrade-typescript-docgen`](https://github.com/storybookjs/storybook/tree/shilman/28269-downgrade-typescript-docgen) | | **Commit** | [`d5ba8e56`](https://github.com/storybookjs/storybook/commit/d5ba8e56e787a3e860e053fc076fe6b818376ab9) | | **Datetime** | Mon Sep 23 10:08:21 UTC 2024 (`1727086101`) | | **Workflow run** | [10992103485](https://github.com/storybookjs/storybook/actions/runs/10992103485) | To request a new release of this pull request, mention the `@storybookjs/core` team. _core team members can create a new canary release [here](https://github.com/storybookjs/storybook/actions/workflows/canary-release-pr.yml) or locally with `gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=29184`_Greptile Summary
This pull request downgrades the @joshwooding/vite-plugin-react-docgen-typescript dependency to address a performance issue with Hot Module Replacement (HMR) in Storybook's React-Vite framework.
code/frameworks/react-vite/package.json
to downgrade @joshwooding/vite-plugin-react-docgen-typescript from 0.3.1 to 0.3.0