storybookjs / storybook

Storybook is the industry standard workshop for building, documenting, and testing UI components in isolation
https://storybook.js.org
MIT License
84.08k stars 9.25k forks source link

CLI: Show constraints in error when getting depndencies #29187

Closed andrasczeh closed 3 days ago

andrasczeh commented 4 days ago

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

Checklist for Maintainers

๐Ÿฆ‹ Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

_core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>_

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 77.5 MB 77.5 MB 100 B 3.74 0%
initSize 162 MB 162 MB 118 B 0.39 0%
diffSize 85 MB 85 MB 18 B -0.45 0%
buildSize 7.57 MB 7.57 MB 0 B -0.42 0%
buildSbAddonsSize 1.66 MB 1.66 MB 0 B -0.42 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 2.34 MB 2.34 MB 0 B - 0%
buildSbPreviewSize 352 kB 352 kB 0 B - 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 4.55 MB 4.55 MB 0 B -0.42 0%
buildPreviewSize 3.02 MB 3.02 MB 0 B -0.42 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 17.5s 22.7s 5.2s 0.98 22.9%
generateTime 22.8s 19.5s -3s -357ms -0.71 -17.2%
initTime 14.6s 15s 479ms -0.8 3.2%
buildTime 9.9s 10.7s 819ms -0.46 7.6%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 6.6s 8.7s 2.1s 2.84 ๐Ÿ”บ24.7%
devManagerResponsive 4.4s 5.7s 1.3s 3 ๐Ÿ”บ23.7%
devManagerHeaderVisible 782ms 1.1s 355ms 4.57 ๐Ÿ”บ31.2%
devManagerIndexVisible 817ms 1.1s 356ms 4.14 ๐Ÿ”บ30.3%
devStoryVisibleUncached 1.3s 2.1s 790ms 3.19 ๐Ÿ”บ37.3%
devStoryVisible 816ms 1.1s 373ms 4.35 ๐Ÿ”บ31.4%
devAutodocsVisible 632ms 1s 390ms 3.07 ๐Ÿ”บ38.2%
devMDXVisible 666ms 1s 421ms 4.83 ๐Ÿ”บ38.7%
buildManagerHeaderVisible 716ms 895ms 179ms 1.1 20%
buildManagerIndexVisible 722ms 897ms 175ms 0.79 19.5%
buildStoryVisible 782ms 934ms 152ms 0.87 16.3%
buildAutodocsVisible 664ms 881ms 217ms 1.73 ๐Ÿ”บ24.6%
buildMDXVisible 652ms 858ms 206ms 1.81 ๐Ÿ”บ24%

Greptile Summary

This PR updates the error message in the latestVersion method of the JsPackageManager class to provide more detailed information about package version constraints.

nx-cloud[bot] commented 4 days ago

โ˜๏ธ Nx Cloud Report

CI is running/has finished running commands for commit af8d7573c6b8330431e15f51cdd18420e5a49fa7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

๐Ÿ“‚ See all runs for this CI Pipeline Execution


โœ… Successfully ran 1 target - [`nx run-many -t build --parallel=3`](https://cloud.nx.app/runs/vmvFgHuRge?utm_source=pull-request&utm_medium=comment)

Sent with ๐Ÿ’Œ from NxCloud.