storybookjs / storybook

Storybook is the industry standard workshop for building, documenting, and testing UI components in isolation
https://storybook.js.org
MIT License
84.08k stars 9.25k forks source link

Optimize: Production-mode `react` in manager #29197

Closed ndelangen closed 2 days ago

ndelangen commented 3 days ago

Closes https://github.com/storybookjs/storybook/issues/29166

What I did

Before: Screenshot 2024-09-24 at 15 14 21

After: Screenshot 2024-09-24 at 15 14 32

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

Checklist for Maintainers

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

_core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>_

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 77.5 MB 77.5 MB 659 B 1.21 0%
initSize 162 MB 162 MB -372 kB -3.83 -0.2%
diffSize 85 MB 84.6 MB -373 kB -23.62 -0.4%
buildSize 7.57 MB 7.19 MB -384 kB -29160.19 🔰-5.3%
buildSbAddonsSize 1.66 MB 1.66 MB 0 B - 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 2.34 MB 1.96 MB -384 kB -42240.73 🔰-19.6%
buildSbPreviewSize 352 kB 352 kB 0 B - 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 4.55 MB 4.17 MB -384 kB -42240.73 🔰-9.2%
buildPreviewSize 3.02 MB 3.02 MB 0 B -2.31 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 7.5s 18.5s 10.9s 0.72 59.3%
generateTime 25.3s 22.7s -2s -599ms 0.16 -11.4%
initTime 22.7s 19.7s -3s -11ms 0.8 -15.3%
buildTime 14.4s 11.3s -3s -72ms -0.1 -27%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 6.3s 6.3s 7ms -1 0.1%
devManagerResponsive 4.2s 4.2s 5ms -1.06 0.1%
devManagerHeaderVisible 758ms 552ms -206ms -2.42 🔰-37.3%
devManagerIndexVisible 800ms 594ms -206ms -2.18 🔰-34.7%
devStoryVisibleUncached 1.2s 1.1s -68ms -0.66 -5.8%
devStoryVisible 799ms 595ms -204ms -2.23 🔰-34.3%
devAutodocsVisible 661ms 381ms -280ms -2.46 🔰-73.5%
devMDXVisible 625ms 435ms -190ms -2.25 🔰-43.7%
buildManagerHeaderVisible 677ms 498ms -179ms -2.8 🔰-35.9%
buildManagerIndexVisible 678ms 501ms -177ms -2.85 🔰-35.3%
buildStoryVisible 738ms 578ms -160ms -2.43 🔰-27.7%
buildAutodocsVisible 617ms 451ms -166ms -2.78 🔰-36.8%
buildMDXVisible 624ms 509ms -115ms -1.74 🔰-22.6%
nx-cloud[bot] commented 3 days ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 56a312e2886043ae0b3e4645b23f803cd98e045b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target - [`nx run-many -t build --parallel=3`](https://cloud.nx.app/runs/RRN4kYdfzg?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

ndelangen commented 3 days ago

I tested the react devtools, and the behavior seems unchanged