Closed yannbf closed 1 month ago
CI is running/has finished running commands for commit 9570872cdc490d553e3a0b72b0fe63b1f8395a28. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
๐ See all runs for this CI Pipeline Execution
Sent with ๐ from NxCloud.
Closes https://github.com/storybookjs/storybook/issues/29213
What I did
This PR introduces changes in the sandbox script to register addon test in vite-based sandboxes, as well as add an E2E to test the entire flow. It also fixes a bug where the test runner was crashing.
Unfortunately I had to add a resolution to a beta version of Vitest 2.1. That's because Vitest 2.1 introduced a bug when changing from fast-glob to tinyglobby, which is a library that does not support symlinks. This means that the addon test stories are not picked up and therefore the E2E tests would fail.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
Checklist for Maintainers
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
[ ] Make sure this PR contains one of the labels below:
Available labels
- `bug`: Internal changes that fixes incorrect behavior. - `maintenance`: User-facing maintenance tasks. - `dependencies`: Upgrading (sometimes downgrading) dependencies. - `build`: Internal-facing build tooling & test updates. Will not show up in release changelog. - `cleanup`: Minor cleanup style change. Will not show up in release changelog. - `documentation`: Documentation **only** changes. Will not show up in release changelog. - `feature request`: Introducing a new feature. - `BREAKING CHANGE`: Changes that break compatibility in some way with current major version. - `other`: Changes that don't fit in the above categories.๐ฆ Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here._core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>
_Greptile Summary
This PR introduces changes to register the addon test in vite-based sandboxes and adds E2E tests for the addon test functionality. Key modifications include:
code/addons/test/template/stories/basics.stories.ts
code/addons/test/src/node/vitest-manager.ts
for better Storybook integrationcode/core/src/manager/components/sidebar/Tree.tsx
for improved test status displaycode/e2e-tests/component-testing.spec.ts
scripts/tasks/sandbox-parts.ts
to include addon test in vite-based sandboxesNote: PR is currently blocked due to a Vitest 2.1 bug affecting symlink support, preventing addon test stories from being picked up.