storybookjs / storybook

Storybook is the industry standard workshop for building, documenting, and testing UI components in isolation
https://storybook.js.org
MIT License
84.08k stars 9.25k forks source link

A11y: Improve test runner recipe #29226

Open shilman opened 1 day ago

shilman commented 1 day ago

Closes N/A

What I did

Also reuse the a11y addon's custom element selector on the test runner, if the user has set it.

Checklist for Contributors

Testing

Manual testing

Did not manual test, but should be simple enough to create a story with a custom element selector and run it in the test runner.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

_core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>_

Greptile Summary

This change enhances the accessibility testing configuration in the Storybook test runner by allowing custom element selectors in story parameters.

nx-cloud[bot] commented 1 day ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8ab6f623e092b55da2c5aa7a991436e1cfa2ca2e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target - [`nx run-many -t build --parallel=3`](https://cloud.nx.app/runs/iqCvVgyRKT?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.