storybookjs / storybook

Storybook is the industry standard workshop for building, documenting, and testing UI components in isolation
https://storybook.js.org
MIT License
84.08k stars 9.25k forks source link

Angular: Support statsJson in angular schemas #29233

Open yannbf opened 20 hours ago

yannbf commented 20 hours ago

Closes #

What I did

this PR introduced the flag and added handling of statsJson in angular, but an important piece was missing: to update the angular schema to include that flag as well. This PR introduces it.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

Checklist for Maintainers

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

_core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>_

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 77.7 MB 77.7 MB 0 B 2.1 0%
initSize 152 MB 152 MB 0 B -4.35 0%
diffSize 74.3 MB 74.3 MB 0 B -4.35 0%
buildSize 6.96 MB 6.96 MB 0 B -1.4 0%
buildSbAddonsSize 1.57 MB 1.57 MB 0 B -1.53 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.91 MB 1.91 MB 0 B -1.28 0%
buildSbPreviewSize 311 kB 311 kB 0 B -1.53 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.98 MB 3.98 MB 0 B -1.38 0%
buildPreviewSize 2.97 MB 2.97 MB 0 B -1.53 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 21.4s 7.9s -13s -430ms -0.36 -168.4%
generateTime 19.1s 30.1s 10.9s 1.65 🔺36.3%
initTime 14.2s 19.9s 5.6s 0.85 28.3%
buildTime 8.5s 9.2s 767ms -1.21 8.3%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 7.1s 6.9s -204ms -0.37 -2.9%
devManagerResponsive 4.5s 4s -486ms -1.39 🔰-11.9%
devManagerHeaderVisible 608ms 586ms -22ms -1.23 -3.8%
devManagerIndexVisible 648ms 651ms 3ms -0.96 0.5%
devStoryVisibleUncached 1.3s 1.4s 117ms 0.37 8.1%
devStoryVisible 646ms 662ms 16ms -0.92 2.4%
devAutodocsVisible 643ms 513ms -130ms -0.94 -25.3%
devMDXVisible 576ms 502ms -74ms -1 -14.7%
buildManagerHeaderVisible 575ms 562ms -13ms -0.85 -2.3%
buildManagerIndexVisible 606ms 876ms 270ms 1.44 🔺30.8%
buildStoryVisible 608ms 876ms 268ms 1.17 30.6%
buildAutodocsVisible 573ms 468ms -105ms -1.41 🔰-22.4%
buildMDXVisible 526ms 481ms -45ms -1.12 -9.4%

Greptile Summary

This PR adds support for the 'statsJson' option in Angular's build-storybook and start-storybook schemas, enhancing configuration options for Storybook in Angular projects.

nx-cloud[bot] commented 20 hours ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5461f739e21869d595f4210619d60e65e1c5b108. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target - [`nx run-many -t build --parallel=3`](https://cloud.nx.app/runs/mWLiIKUTtz?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.