storybookjs / storybook

Storybook is the industry standard workshop for building, documenting, and testing UI components in isolation
https://storybook.js.org
MIT License
84.68k stars 9.32k forks source link

CLI: Fix Solid init by installing `@storybook/test` #29514

Closed shilman closed 2 weeks ago

shilman commented 2 weeks ago

Closes N/A

What I did

We recently released https://github.com/storybookjs/solidjs/releases/tag/v1.0.0-beta.3 that updates the CLI templates to use @storybook/test instead of @storybook/testing-library. This storybook init in a Solid project.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

Manual testing

If we were to release a canary, install it in a fresh Solid project. I've tested by hand already & it's a simple enough change.

At some point we should get the Solid sandboxes back into shape!

šŸ¦‹ Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

_core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>_

Greptile Summary

Updates the Solid.js project initialization in Storybook CLI to use @storybook/test instead of @storybook/testing-library, aligning with the recent storybook-solidjs@1.0.0-beta.3 release.

nx-cloud[bot] commented 2 weeks ago

ā˜ļø Nx Cloud Report

CI is running/has finished running commands for commit a10154ebc7d968640711f5cf20288e12e16fc2bf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

šŸ“‚ See all runs for this CI Pipeline Execution


āœ… Successfully ran 2 targets - [`nx affected -t check -c production --parallel=7`](https://cloud.nx.app/runs/Ou25TP4vcL?utm_source=pull-request&utm_medium=comment) - [`nx run-many -t build -c production --parallel=3`](https://cloud.nx.app/runs/dnHyRX8YzD?utm_source=pull-request&utm_medium=comment)

Sent with šŸ’Œ from NxCloud.