Closed shilman closed 2 weeks ago
CI is running/has finished running commands for commit a10154ebc7d968640711f5cf20288e12e16fc2bf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
š See all runs for this CI Pipeline Execution
Sent with š from NxCloud.
Closes N/A
What I did
We recently released https://github.com/storybookjs/solidjs/releases/tag/v1.0.0-beta.3 that updates the CLI templates to use
@storybook/test
instead of@storybook/testing-library
. Thisstorybook init
in a Solid project.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
If we were to release a canary, install it in a fresh Solid project. I've tested by hand already & it's a simple enough change.
At some point we should get the Solid sandboxes back into shape!
š¦ Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here._core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>
_Greptile Summary
Updates the Solid.js project initialization in Storybook CLI to use
@storybook/test
instead of@storybook/testing-library
, aligning with the recentstorybook-solidjs@1.0.0-beta.3
release.code/lib/create-storybook/src/generators/baseGenerator.ts
to use@storybook/test
for Solid.js projects@storybook/testing-library
for Qwik projects only