storybookjs / storybook

Storybook is the industry standard workshop for building, documenting, and testing UI components in isolation
https://storybook.js.org
MIT License
84.68k stars 9.32k forks source link

Core: Prevent clipping box shadow on file search modal #29523

Closed ghengeveld closed 1 week ago

ghengeveld commented 1 week ago

The box shadow on the file search modal was being clipped on the sides:

Screenshot 2024-11-04 at 12 12 28

Overriding overflow: hidden fixes this and is safe to do because the inner ModalChild wrapper already does that.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

Checklist for Maintainers

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

_core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>_

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 78.1 MB 78.2 MB 51.9 kB 1.28 0.1%
initSize 143 MB 143 MB 51.9 kB 1.3 0%
diffSize 65.1 MB 65.1 MB 23 B 1.42 0%
buildSize 6.88 MB 6.88 MB 23 B 1.74 0%
buildSbAddonsSize 1.51 MB 1.51 MB 0 B - 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.9 MB 1.9 MB 23 B 1.73 0%
buildSbPreviewSize 271 kB 271 kB 0 B - 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.88 MB 3.88 MB 23 B 1.73 0%
buildPreviewSize 3 MB 3 MB 0 B 1.73 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 8.2s 23.2s 14.9s 1.47 🔺64.5%
generateTime 25.5s 22.2s -3s -254ms -0.21 -14.6%
initTime 17.6s 14.8s -2s -888ms -0.66 -19.5%
buildTime 8.7s 9.5s 732ms 0.56 7.7%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 6.5s 6.3s -197ms 0.25 -3.1%
devManagerResponsive 4.4s 3.9s -532ms -0.04 -13.6%
devManagerHeaderVisible 604ms 564ms -40ms -0.63 -7.1%
devManagerIndexVisible 693ms 599ms -94ms -0.9 -15.7%
devStoryVisibleUncached 1.1s 819ms -360ms -0.88 -44%
devStoryVisible 686ms 598ms -88ms -0.82 -14.7%
devAutodocsVisible 577ms 521ms -56ms -0.39 -10.7%
devMDXVisible 558ms 549ms -9ms 0.01 -1.6%
buildManagerHeaderVisible 682ms 706ms 24ms 1.07 3.4%
buildManagerIndexVisible 704ms 712ms 8ms 0.95 1.1%
buildStoryVisible 680ms 703ms 23ms 1.06 3.3%
buildAutodocsVisible 478ms 480ms 2ms -0.07 0.4%
buildMDXVisible 511ms 472ms -39ms -0.15 -8.3%

Greptile Summary

Fixed box shadow clipping in the file search modal by modifying overflow behavior in the styled modal component.

nx-cloud[bot] commented 1 week ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 909297a014e4d53fa470c91fcab57c6300f112d1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target - [`nx affected -t check -c production --parallel=7`](https://cloud.nx.app/runs/9SuPn2U1xt?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.