Open valentinpalkovic opened 1 week ago
CI is running/has finished running commands for commit fd7f82f1f620ba07de603f2135420cfcf451a2ba. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud.
Closes https://github.com/storybookjs/storybook/issues/29467
What I did
I have rewritten
rehype
imports to dynamic imports so that the import doesn't break in CJS environments.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
Checklist for Maintainers
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.ts
[ ] Make sure this PR contains one of the labels below:
Available labels
- `bug`: Internal changes that fixes incorrect behavior. - `maintenance`: User-facing maintenance tasks. - `dependencies`: Upgrading (sometimes downgrading) dependencies. - `build`: Internal-facing build tooling & test updates. Will not show up in release changelog. - `cleanup`: Minor cleanup style change. Will not show up in release changelog. - `documentation`: Documentation **only** changes. Will not show up in release changelog. - `feature request`: Introducing a new feature. - `BREAKING CHANGE`: Changes that break compatibility in some way with current major version. - `other`: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-29544-sha-fd7f82f1
. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-29544-sha-fd7f82f1 sandbox
or in an existing project withnpx storybook@0.0.0-pr-29544-sha-fd7f82f1 upgrade
.More information
| | | | --- | --- | | **Published version** | [`0.0.0-pr-29544-sha-fd7f82f1`](https://npmjs.com/package/storybook/v/0.0.0-pr-29544-sha-fd7f82f1) | | **Triggered by** | @valentinpalkovic | | **Repository** | [storybookjs/storybook](https://github.com/storybookjs/storybook) | | **Branch** | [`valentin/dynamic-import-of-rehype`](https://github.com/storybookjs/storybook/tree/valentin/dynamic-import-of-rehype) | | **Commit** | [`fd7f82f1`](https://github.com/storybookjs/storybook/commit/fd7f82f1f620ba07de603f2135420cfcf451a2ba) | | **Datetime** | Tue Nov 5 11:21:27 UTC 2024 (`1730805687`) | | **Workflow run** | [11683115704](https://github.com/storybookjs/storybook/actions/runs/11683115704) | To request a new release of this pull request, mention the `@storybookjs/core` team. _core team members can create a new canary release [here](https://github.com/storybookjs/storybook/actions/workflows/canary-release-pr.yml) or locally with `gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=29544`_Greptile Summary
Modified the import method for rehype plugins in MDX-related files to use dynamic imports instead of static imports, improving CommonJS environment compatibility.
await import()
incode/addons/docs/src/plugins/mdx-plugin.ts
code/addons/docs/src/preset.ts
to use dynamic imports