Open toothlessdev opened 5 days ago
CI is running/has finished running commands for commit 7b7e3a78a4e071928661661860a2d5220b2ff1bb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud.
Closes #29408
What I did
Add test code for disable withTelemetry when
--no-version-updates
flag is enabled in cliOptions Disable Telemetry when--no-version-updates
flag is enabled in cliOptionsChecklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
Checklist for Maintainers
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.ts
[ ] Make sure this PR contains one of the labels below:
Available labels
- `bug`: Internal changes that fixes incorrect behavior. - `maintenance`: User-facing maintenance tasks. - `dependencies`: Upgrading (sometimes downgrading) dependencies. - `build`: Internal-facing build tooling & test updates. Will not show up in release changelog. - `cleanup`: Minor cleanup style change. Will not show up in release changelog. - `documentation`: Documentation **only** changes. Will not show up in release changelog. - `feature request`: Introducing a new feature. - `BREAKING CHANGE`: Changes that break compatibility in some way with current major version. - `other`: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here._core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>
_Greptile Summary
This PR modifies Storybook's telemetry behavior to respect the
--no-version-updates
CLI flag, ensuring telemetry is disabled when version updates are disabled.code/core/src/core-server/withTelemetry.ts
to disable telemetry whenoptions.cliOptions.versionUpdates === false
withTelemetry.test.ts
to verify telemetry is not called whenversionUpdates
is falsedisableTelemetry
flag andSTORYBOOK_DISABLE_TELEMETRY
env var