Closed yannbf closed 2 days ago
CI is running/has finished running commands for commit 6a1bbc47aeda37b398d249a16580e8f8f964ace1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud.
Commit: 6a1bbc4
, ran on 19 November 2024 at 18:56:46 UTC
The following packages have significant changes to their size or dependencies:
@storybook/core
Before | After | Difference | |
---|---|---|---|
Dependency count | 46 | 46 | 0 |
Self size | 19.24 MB | 19.08 MB | 🎉 -169 KB 🎉 |
Dependency size | 14.29 MB | 14.29 MB | 0 B |
Bundle Size Analyzer | Link | Link |
@storybook/experimental-nextjs-vite
Before | After | Difference | |
---|---|---|---|
Dependency count | 87 | 87 | 0 |
Self size | 230 KB | 231 KB | 🚨 +161 B 🚨 |
Dependency size | 31.03 MB | 31.30 MB | 🚨 +269 KB 🚨 |
Bundle Size Analyzer | Link | Link |
storybook
Before | After | Difference | |
---|---|---|---|
Dependency count | 47 | 47 | 0 |
Self size | 22 KB | 22 KB | 0 B |
Dependency size | 33.54 MB | 33.37 MB | 🎉 -169 KB 🎉 |
Bundle Size Analyzer | Link | Link |
sb
Before | After | Difference | |
---|---|---|---|
Dependency count | 48 | 48 | 0 |
Self size | 1 KB | 1 KB | 0 B |
Dependency size | 33.56 MB | 33.39 MB | 🎉 -169 KB 🎉 |
Bundle Size Analyzer | Link | Link |
@storybook/cli
Before | After | Difference | |
---|---|---|---|
Dependency count | 390 | 390 | 0 |
Self size | 483 KB | 483 KB | 🎉 -282 B 🎉 |
Dependency size | 74.60 MB | 74.43 MB | 🎉 -172 KB 🎉 |
Bundle Size Analyzer | Link | Link |
@storybook/codemod
Before | After | Difference | |
---|---|---|---|
Dependency count | 270 | 270 | 0 |
Self size | 612 KB | 612 KB | 0 B |
Dependency size | 64.60 MB | 64.43 MB | 🎉 -169 KB 🎉 |
Bundle Size Analyzer | Link | Link |
create-storybook
Before | After | Difference | |
---|---|---|---|
Dependency count | 105 | 105 | 0 |
Self size | 1.11 MB | 1.11 MB | 🎉 -3 KB 🎉 |
Dependency size | 42.54 MB | 42.37 MB | 🎉 -169 KB 🎉 |
Bundle Size Analyzer | Link | Link |
Closes #
What I did
This PR adds Next.js 15 support to the nextjs-vite framework. This requires changes in the vite-plugin-next repo which are accounted for in https://github.com/storybookjs/vite-plugin-storybook-nextjs/pull/27
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
Checklist for Maintainers
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.ts
[ ] Make sure this PR contains one of the labels below:
Available labels
- `bug`: Internal changes that fixes incorrect behavior. - `maintenance`: User-facing maintenance tasks. - `dependencies`: Upgrading (sometimes downgrading) dependencies. - `build`: Internal-facing build tooling & test updates. Will not show up in release changelog. - `cleanup`: Minor cleanup style change. Will not show up in release changelog. - `documentation`: Documentation **only** changes. Will not show up in release changelog. - `feature request`: Introducing a new feature. - `BREAKING CHANGE`: Changes that break compatibility in some way with current major version. - `other`: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-29640-sha-e762e5df
. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-29640-sha-e762e5df sandbox
or in an existing project withnpx storybook@0.0.0-pr-29640-sha-e762e5df upgrade
.More information
| | | | --- | --- | | **Published version** | [`0.0.0-pr-29640-sha-e762e5df`](https://npmjs.com/package/storybook/v/0.0.0-pr-29640-sha-e762e5df) | | **Triggered by** | @yannbf | | **Repository** | [storybookjs/storybook](https://github.com/storybookjs/storybook) | | **Branch** | [`yann/next-15-support-vite`](https://github.com/storybookjs/storybook/tree/yann/next-15-support-vite) | | **Commit** | [`e762e5df`](https://github.com/storybookjs/storybook/commit/e762e5dfc503fd87301cf2459324e155b1d02343) | | **Datetime** | Tue Nov 19 15:56:35 UTC 2024 (`1732031795`) | | **Workflow run** | [11916826559](https://github.com/storybookjs/storybook/actions/runs/11916826559) | To request a new release of this pull request, mention the `@storybookjs/core` team. _core team members can create a new canary release [here](https://github.com/storybookjs/storybook/actions/workflows/canary-release-pr.yml) or locally with `gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=29640`_Greptile Summary
Added support for Next.js 15 in Storybook's experimental Next.js Vite framework, with key updates to package dependencies, compatibility layers, and template stories.
package.json
to support Next.js 15 with peer dependencies^14.1.0 || ^15.0.0
and updatedvite-plugin-storybook-nextjs
to canary versionNextHeader.tsx
andServerActions.tsx
for Next.js 15's asynchronous cookies/headers APIsdraftMode
indraft-mode.compat.ts
to handle Next.js version differencesexperimental-nextjs-vite/14-ts
while updatingdefault-ts
for latest Next.js version