storybookjs / storybook

Storybook is the industry standard workshop for building, documenting, and testing UI components in isolation
https://storybook.js.org
MIT License
84.72k stars 9.32k forks source link

Add discrepancy handling to A11yPanel #29661

Closed valentinpalkovic closed 2 days ago

valentinpalkovic commented 3 days ago

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

Checklist for Maintainers

🦋 Canary release

This pull request has been released as version 0.0.0-pr-29661-sha-2eebee12. Try it out in a new sandbox by running npx storybook@0.0.0-pr-29661-sha-2eebee12 sandbox or in an existing project with npx storybook@0.0.0-pr-29661-sha-2eebee12 upgrade.

More information | | | | --- | --- | | **Published version** | [`0.0.0-pr-29661-sha-2eebee12`](https://npmjs.com/package/storybook/v/0.0.0-pr-29661-sha-2eebee12) | | **Triggered by** | @valentinpalkovic | | **Repository** | [storybookjs/storybook](https://github.com/storybookjs/storybook) | | **Branch** | [`valentin/add-a11y-discrepancy-handling`](https://github.com/storybookjs/storybook/tree/valentin/add-a11y-discrepancy-handling) | | **Commit** | [`2eebee12`](https://github.com/storybookjs/storybook/commit/2eebee1264ecfead76a5fd6818f61bad84a2de26) | | **Datetime** | Tue Nov 19 15:05:09 UTC 2024 (`1732028709`) | | **Workflow run** | [11915852041](https://github.com/storybookjs/storybook/actions/runs/11915852041) | To request a new release of this pull request, mention the `@storybookjs/core` team. _core team members can create a new canary release [here](https://github.com/storybookjs/storybook/actions/workflows/canary-release-pr.yml) or locally with `gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=29661`_

Greptile Summary

Added discrepancy handling to the A11YPanel component to detect and display messages when accessibility test results differ between CLI and browser environments.

nx-cloud[bot] commented 3 days ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 79ad98cbe88aae0ade60b6ea2d017c05c4e2b9f2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target - [`nx run-many -t build --parallel=3`](https://cloud.nx.app/runs/rugUajv5p2?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.