storybookjs / storybook

Storybook is the industry standard workshop for building, documenting, and testing UI components in isolation
https://storybook.js.org
MIT License
84.72k stars 9.32k forks source link

Addon Test: Use pathe for better windows support #29676

Closed yannbf closed 1 day ago

yannbf commented 2 days ago

Closes https://github.com/storybookjs/storybook/issues/29570

What I did

I replaced the usage of node:path with pathe for proper Windows support.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

Checklist for Maintainers

šŸ¦‹ Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

_core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>_

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 78.4 MB 78.4 MB 4.11 kB -0.16 0%
initSize 144 MB 144 MB 4.11 kB -0.58 0%
diffSize 65.1 MB 65.1 MB 0 B -0.83 0%
buildSize 6.83 MB 6.83 MB 0 B -1.05 0%
buildSbAddonsSize 1.51 MB 1.51 MB 0 B - 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.86 MB 1.86 MB 0 B -1.09 0%
buildSbPreviewSize 271 kB 271 kB 0 B - 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.83 MB 3.83 MB 0 B -1.09 0%
buildPreviewSize 3 MB 3 MB 0 B 0.95 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 15.5s 8.4s -7s -27ms -1.41 šŸ”°-82.9%
generateTime 19.4s 25.4s 5.9s 1.18 23.4%
initTime 13.3s 14.8s 1.4s -0.02 9.5%
buildTime 7.7s 7.9s 218ms -0.94 2.7%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 5.8s 6.8s 963ms 1.71 šŸ”ŗ14.1%
devManagerResponsive 3.5s 4.1s 613ms 1.83 šŸ”ŗ14.7%
devManagerHeaderVisible 587ms 867ms 280ms 4.55 šŸ”ŗ32.3%
devManagerIndexVisible 668ms 968ms 300ms 4.06 šŸ”ŗ31%
devStoryVisibleUncached 1.2s 1.4s 244ms 2.34 šŸ”ŗ16.4%
devStoryVisible 624ms 959ms 335ms 4.32 šŸ”ŗ34.9%
devAutodocsVisible 542ms 738ms 196ms 4.71 šŸ”ŗ26.6%
devMDXVisible 701ms 831ms 130ms 4.37 šŸ”ŗ15.6%
buildManagerHeaderVisible 584ms 737ms 153ms 2.9 šŸ”ŗ20.8%
buildManagerIndexVisible 603ms 752ms 149ms 2.72 šŸ”ŗ19.8%
buildStoryVisible 583ms 736ms 153ms 2.85 šŸ”ŗ20.8%
buildAutodocsVisible 479ms 579ms 100ms 1.84 šŸ”ŗ17.3%
buildMDXVisible 478ms 605ms 127ms 3.11 šŸ”ŗ21%
storybook-bot commented 2 days ago

Failed to publish canary version of this pull request, triggered by @yannbf. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/11938646828

nx-cloud[bot] commented 2 days ago

ā˜ļø Nx Cloud Report

CI is running/has finished running commands for commit 13e54a028b9a4005142b113693e839218ca9c612. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

šŸ“‚ See all runs for this CI Pipeline Execution


āœ… Successfully ran 1 target - [`nx run-many -t build --parallel=3`](https://cloud.nx.app/runs/kZxsbzQrkM?utm_source=pull-request&utm_medium=comment)

Sent with šŸ’Œ from NxCloud.

storybook-pr-benchmarking[bot] commented 1 day ago

Package Benchmarks

Commit: 13e54a0, ran on 21 November 2024 at 09:00:28 UTC

The following packages have significant changes to their size or dependencies:

@storybook/experimental-addon-test

Before After Difference
Dependency count 61 61 0
Self size 587 KB 605 KB šŸšØ +17 KB šŸšØ
Dependency size 13.86 MB 13.86 MB 0 B
Bundle Size Analyzer Link Link
storybook-bot commented 1 day ago

Failed to publish canary version of this pull request, triggered by @yannbf. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/11952594770