storybookjs / storybook

Storybook is the industry standard workshop for building, documenting, and testing UI components in isolation
https://storybook.js.org
MIT License
84.75k stars 9.33k forks source link

Angular: Default to standalone components in Angular v19 #29677

Closed ingowagner closed 4 days ago

ingowagner commented 5 days ago

Closes #29671

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

Checklist for Maintainers

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

_core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>_

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 78.4 MB 78.4 MB 0 B -0.22 0%
initSize 144 MB 144 MB 0 B -0.64 0%
diffSize 65.1 MB 65.1 MB 0 B -0.83 0%
buildSize 6.83 MB 6.83 MB 0 B -1.05 0%
buildSbAddonsSize 1.51 MB 1.51 MB 0 B - 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.86 MB 1.86 MB 0 B -1.09 0%
buildSbPreviewSize 271 kB 271 kB 0 B - 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.83 MB 3.83 MB 0 B -1.09 0%
buildPreviewSize 3 MB 3 MB 0 B 0.95 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 15.5s 6.6s -8s -879ms -1.7 🔰-134.1%
generateTime 19.4s 19.4s -24ms -0.55 -0.1%
initTime 13.3s 13.1s -211ms -1.01 -1.6%
buildTime 7.7s 7.5s -179ms -1.33 -2.4%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 5.8s 7.5s 1.6s 2.84 🔺22.4%
devManagerResponsive 3.5s 4.6s 1.1s 3.34 🔺24%
devManagerHeaderVisible 587ms 736ms 149ms 2.6 🔺20.2%
devManagerIndexVisible 668ms 832ms 164ms 2.41 🔺19.7%
devStoryVisibleUncached 1.2s 1.1s -108ms 0.54 -9.5%
devStoryVisible 624ms 824ms 200ms 2.6 🔺24.3%
devAutodocsVisible 542ms 739ms 197ms 4.73 🔺26.7%
devMDXVisible 701ms 674ms -27ms 2.22 -4%
buildManagerHeaderVisible 584ms 850ms 266ms 4.68 🔺31.3%
buildManagerIndexVisible 603ms 910ms 307ms 5.08 🔺33.7%
buildStoryVisible 583ms 849ms 266ms 4.6 🔺31.3%
buildAutodocsVisible 479ms 608ms 129ms 2.34 🔺21.2%
buildMDXVisible 478ms 611ms 133ms 3.23 🔺21.8%

Greptile Summary

This PR modifies the standalone component behavior in Angular's PropertyExtractor to align with Angular 19's new default where components are standalone by default unless explicitly specified otherwise.

yannbf commented 5 days ago

Hey @ingowagner thank you so much for your contribution! <3

nx-cloud[bot] commented 5 days ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1c9f923dc79f5e06c84820c5cfe275a767304dbe. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target - [`nx run-many -t build --parallel=3`](https://cloud.nx.app/runs/HS0XY59Sk1?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.