[Investigation]: Support React 19 - Githubissues

storybookjs / storybook

Storybook is the industry standard workshop for building, documenting, and testing UI components in isolation

https://storybook.js.org

MIT License

84.84k stars 9.34k forks source link

[Investigation]: Support React 19 #29805

Open yannbf opened 14 hours ago

yannbf commented 14 hours ago

Describe the bug

React 19 is currently at the RC stage. We should investigate all the changes that are needed to support it before release:

Make sure that React 19 is supported in all packages that have it as direct dependency or peer dependency
- @storybook/addon-docs
- @storybook/addon-links
- @storybook/ember
- @storybook/blocks
- @storybook/react
- @storybook/react-vite
- @storybook/react-webpack5
- @storybook/react-dom-shim
- @storybook/react-webpack
- @storybook/experimental-nextjs-vite
- @storybook/react-native-web-vite
- @storybook/nextjs
- @storybook/icons
Make sure React 19 features are tested in sandboxes
Update usage of act in places like this
(optional) Update addon-toolkit to use React 19

Reproduction link

-

Reproduction steps

No response

System

Additional context

No response

JReinhold commented 13 hours ago

I don't think we want to upgrade any direct dependencies, as that would be a breaking change, at least if we did it in @storybook/addon-docs or storybook. We also shouldn't upgrade devDependencies in addons, and especially not addon-kit, because the manager will still be using React 18, so the addons' React version is ignored. Meaning if you're building an addon with React 19 APIs, they won't work as soon as that addon is bundled into the manager at runtime.