search

storybookjs / storybook

Storybook is the industry standard workshop for building, documenting, and testing UI components in isolation
https://storybook.js.org
MIT License
83.96k stars 9.22k forks source link

Update code owners #6223

Closed shilman closed 5 years ago

shilman commented 5 years ago

@Hypnosphi recently removed himself from code owners and it occurred to me that this file hasn't been maintained.

I think we should either delete the file or come up with a better policy for this.

Here's a strawman for discussion. Being a code owner:

I've personally managed every incoming issue and PR for the past few weeks as part of the v5 release, and it would help that process immensely. For example:

CodeByAlex commented 5 years ago

@shilman would a code owner be the owner of an addon or all of storybook?

If all of storybook, how could we manage routing to people who best know the topic?

Update: sorry accidentally clicked the close button. I reopened

shilman commented 5 years ago

https://help.github.com/en/articles/about-code-owners

Code owners are for subdirectories of the code. They are automatically requested to review pull requests that touch that code. There's no reason we couldn't use the same file to automate other stuff like notifications. Not sure what Github provides natively if anything, but they have a rich API that I've used extensively for automating release-related stuff.

CodeByAlex commented 5 years ago

@shilman, I like the sound of that. I am interested in being a code owner of the a11y addon if we split it up that way. Thanks for considering me.

jsomsanith-tlnd commented 5 years ago

Hey @shilman.

It's an honor to be in this list :D , but I have a question about the commitment. The time I can allocate can be quite low (I just had a 2nd baby :) ). So what do you expect from code owner in practice ? I mean, is it problematic for code owners to be inactive during unknown period of time ?

In either way I'd like to help in questions/reviews when I can.

shilman commented 5 years ago

@jsomsanith congratulations!!!! 🎉👶🍾

As for commitment, I think that's really TBD. First of all this is an OSS project so it's completely voluntary and we all understand that people come and go and that's fine. And it's fundamental. Also, this had better be fun.

Given that, there's a whole range of possible commitment ranging from something very strict (which I'm sure WON'T fly) to none at all (which also isn't so useful).

My strawman would be that as a code owner you agree to get notified for issues/PRs/questions relating to the area that you own, are cool with having people @mention you in Github/Discord related to that topic, and will make an effort subject to your availability, which may change a lot due to work/life commitments to help push that area of the project forward. If it's overwhelming or stops being fun/interesting, step down. And if it becomes reasonable again, step back up again.

Armanio commented 5 years ago

Of course, I agree. 🎉 Honestly, its honor for me. I am ready to do my best.

backbone87 commented 5 years ago

i can offer to be available for reviews/issues/questions regarding @storybook/vue

jsomsanith-tlnd commented 5 years ago

@shilman Thank you :)

Your description seems great, and having notification surely will help to contribute more. Let's go for it :D

leoyli commented 5 years ago

I'm also interested in helping since we are using SB as part of our developing and automated code reviewing tools. It is reasonable to put efforts back to the community and get my bug reports fixed quick. After all, to improve SB is also going to improve my daily workflow, so why not?! I will take some time to see which area or direction I can help.

stale[bot] commented 5 years ago

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

shilman commented 5 years ago

Yee-haw!! I just released https://github.com/storybooks/storybook/releases/tag/v5.1.0-alpha.28 containing PR #6509 that references this issue. Upgrade today to try it out!

Because it's a pre-release you can find it on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

stale[bot] commented 5 years ago

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

stale[bot] commented 5 years ago

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!