search

storybookjs / storybook

Storybook is the industry standard workshop for building, documenting, and testing UI components in isolation
https://storybook.js.org
MIT License
84.21k stars 9.26k forks source link

Addon knobs won't reset to default value when open canvas in new tab #7642

Closed josvdveen closed 5 years ago

josvdveen commented 5 years ago

Describe the bug Changing a knob back to its default setting is not reflecting when opening canvas in a new tab. When opening the story canvas in a new tab, the previous selection of the knob is still active. So for example a Boolean is still true instead of false (default value). This is also reflected in the URL parameters, witch shows true even after the Boolean is set to false (default value).

To Reproduce Steps to reproduce the behavior:

  1. Open a story that has any knobs configurated.
  2. Change, for example a Boolean to true en preview these changes by opening canvas in a new tab.
  3. Close the canvas tab en set the Boolean back to false.
  4. Open canvas in a new tab again and see no changes.

Expected behavior I would expected to see my component back in its default state.

System:

    "@storybook/addon-a11y": "^5.1.9",
    "@storybook/addon-actions": "^5.1.9",
    "@storybook/addon-backgrounds": "^5.1.9",
    "@storybook/addon-jest": "^5.1.9",
    "@storybook/addon-knobs": "^5.1.9",
    "@storybook/addon-links": "^5.1.9",
    "@storybook/addon-notes": "^5.1.9",
    "@storybook/addon-viewport": "^5.1.9",
    "@storybook/addons": "^5.1.9",
    "@storybook/vue": "^5.1.9",
stale[bot] commented 5 years ago

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

stale[bot] commented 5 years ago

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!