search

storybookjs / storybook

Storybook is the industry standard workshop for building, documenting, and testing UI components in isolation
https://storybook.js.org
MIT License
84.59k stars 9.31k forks source link

build-storybook should build stories with "Static Site Generation" (SSG) for improved perf/SEO #9382

Open NateRadebaugh opened 4 years ago

NateRadebaugh commented 4 years ago

Is your feature request related to a problem? Please describe. I'm always frustrated when I navigate to a page and see the page skeleton while the stories are fetched instead of just showing the full menu/first page immediately. There's already a build step, so this seems possible.

Describe the solution you'd like I'd like to see a solution where static pages are generated from stories without showing the generic storybook skeleton: image

Describe alternatives you've considered With tools like Gatsby and NextJS bringing support for SSG, I could set up a separate site that utilizes the new CSF format and maybe host it there, but that wouldn't be ideal.

Are you able to assist bring the feature to reality? Yes with guidance since I don't have familiarity with the storybook internals.

Additional context N/A

shilman commented 4 years ago

Any interest in taking this on @NateRadebaugh? I think @ndelangen knows the bundling issues better than anyone else...

NateRadebaugh commented 4 years ago

Yes I would love to take this on, but I'm not sure where to start. Any hints?

ndelangen commented 4 years ago

@NateRadebaugh Shall we schedule a meeting to talk about this?

You can view my calendar right here: https://calendly.com/ndelangen/storybook

(and even schedule a meeting there)

Looking forward to hear what you have in mind! I can definitely help you understand what's currently going on in the code and assist with potential changes.

stale[bot] commented 4 years ago

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

kalinchernev commented 4 years ago

Still relevant, not stale

On Mon, 24 Feb 2020, 21:15 stale[bot], notifications@github.com wrote:

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/storybookjs/storybook/issues/9382?email_source=notifications&email_token=AAOVTFDI36EFJ3USNLBSC3DREPB7NA5CNFSM4KFKFIL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMXXXAQ#issuecomment-590314370, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOVTFCTB52EQM6F5G4NCS3REPB7NANCNFSM4KFKFILQ .

muratcorlu commented 2 years ago

I think this becomes a bigger issue if we consider using Storybook as the source of truth in our design system. Currently showing a page can take 10 seconds. And when we share links in internet, link previews are broken, since we can not set a proper HTML title and meta tags for every separate pages. For example, currently we see something like that in iMessage when we share a storybook link:

image[^1]

I can see, that would be a big change for current codebase but I think it should definitely be considered for the next big update.

[^1]: This title will be "Storybook loading..." starting from v7 #17709