search

storybookjs / test-runner

🚕 Turn stories into executable tests
https://storybook.js.org/docs/writing-tests/interaction-testing
MIT License
229 stars 72 forks source link

Remove filterered stories from test #449

Open zb-sj opened 5 months ago

zb-sj commented 5 months ago

My sub test only needs one story to test but the current tag filtering implementation creates redundant describe.skip(${title}, () => { it('no-op', () => {}) }); as per makeDescribe

It wastes noticeable time just to skip those tests.

Wouldn't it be better not to generate a description for filtered tests? I see there is skipTags for the exact purpose.

Please let me know what you think and I could probably make a quick PR for this.

yannbf commented 4 months ago

Hey there! I'd appreciate a PR. If I recall correctly, it was not possible to do this because of file transformation limitations.

zb-sj commented 4 months ago

If I recall correctly, it was not possible to do this because of file transformation limitations.

I will have a look, but don't get hopes so high since you would know better than me :)

zb-sj commented 3 months ago

It's been a while but I'm sorry I haven't had much time to look into this. 😢

Please feel free to close this issue for now. I will reopen when I start the work.