search

storybookjs / testing-react

Testing utilities that allow you to reuse your Storybook stories in your React unit tests!
MIT License
588 stars 24 forks source link

Support React@18 #99

Closed alejandronanez closed 2 years ago

alejandronanez commented 2 years ago

Describe the bug I'm currently using React 18 in my project and I'm having issues when I try to install this package because of the react version specified in https://github.com/storybookjs/testing-react/blob/d22cb1c397f273c382aff7920d7d97147d415f83/package.json#L81

Is there anything I can do to help? I suppose I can open a PR to update the peerDeps, but I'm not familiar with the project so I don't know if that fix is going to be "that simple"

To Reproduce Steps to reproduce the behavior:

I can create a repo to reproduce this later today if that's helpful.

Expected behavior I can install the library

Screenshots Additional context Add any other context about the problem here.

alejandronanez commented 2 years ago

Just opened this, https://github.com/storybookjs/testing-react/pull/100 I'm not sure if that's enough!

PeterSHL commented 2 years ago

Any idea when this change will be released?

hkai-jackylo commented 2 years ago

Any idea when this change will be released?

Would like to know too!

github-actions[bot] commented 2 years ago

:rocket: Issue was released in v1.3.0 :rocket:

yannbf commented 2 years ago

Hey everyone! Sorry about this, the PR was not labeled correctly before getting merged. This should be out now in 1.3.0!