search

storybookjs / vue-cli-plugin-storybook

Vue CLI plugin for Storybook
MIT License
279 stars 44 forks source link

Only some properties of vue's webpack config merged. #57

Open Karabur opened 5 years ago

Karabur commented 5 years ago

There are explicit set of vue's config which is merged to storybook's default config. This leads to be impossible to control any fields apart from module, plugins, resolve and resolveLoader.

For example, output section is quite important as vue has well-known sourcemap issues which require custom setup.

Is there any reason why we just dont merge everything from vue's config? if there are, could we consider merging output section at least?

or if there are really heavy weght arguments againts, at least change docs, which states

The webpack config used for storybook is resolved from vue-cli-service, which means you don't need to have any special webpack.config.js in storybook config folder.

and it is actually not true and quite confusing.

pksunkara commented 5 years ago

I would actually like to do it that anyway. I thought the current code helps it, but I am okay to any new ideas which improve it.

backbone87 commented 5 years ago

Maybe the other way around is more useful: Extend the vue cli webpack config with everything needed to run storybook

miljan-aleksic commented 5 years ago

I run into this limitation when trying to add externals, its quite imperative to have full control, one way or another.

weaversam8 commented 4 years ago

I've also run into this when trying to silence progress updates from the webpack process, this setting is also ignored.