storypioneers / kirby-wysiwyg

WYSIWYG panel field for Kirby CMS
Other
125 stars 16 forks source link

Safari Bug #29

Open dpogni opened 8 years ago

dpogni commented 8 years ago

I'm having an issue in Safari. When I'm attempting to edit a page that has wysiwyg enabled, the browser will franticly refresh. I've looked into the JS file, but can't seem to figure out how to fix.

I was able to recreate the issue in a fresh install of kirby and kriby-wysiwyg.

Kirby 2.2.3, Safari 9.0.3

good-idea commented 8 years ago

+1 with Panel 2.2.0 Safari 9.0.3

puppycodes commented 8 years ago

+1 Meeee too Panel 2.2.0 Safari 9.0.3

good-idea commented 8 years ago

I traced this back to line 113 of wysiwyg.js:

        self.$field.bind('destroyed', function() {
              self.editor.deactivate();
        });

Commenting out self.editor.deactivate() stopped the refreshing.

The deactivate function is buried in the minified jQuery UI ~ so my investigation comes to a close ~

puppycodes commented 8 years ago

yessssss!!💃🏻

On Feb 27, 2016, at 12:14 AM, SQbiz notifications@github.com wrote:

I traced this back to line 113 of wysiwyg.js:

    self.$field.bind('destroyed', function() {
          self.editor.deactivate();
    });

Commenting out self.editor.deactivate() stopped the refreshing. Maybe it has something to do with the 'destroyed' event? but that seems less likely.

The deactivate function is buried in the minified jQuery UI ~ so my investigation comes to a close ~

— Reply to this email directly or view it on GitHub.

JonasDoebertin commented 8 years ago

Needs some further investigation. I'll keep this open for now.

dgdsp commented 8 years ago

should be fixed in dev-branch