storyprotocol / protocol-core-v1

core protocol repo for mainnet launch
Other
73 stars 54 forks source link

Add a Switch to Control Protocol Fee #199

Closed kingster-will closed 3 weeks ago

kingster-will commented 2 months ago

Description

We need to implement a switch to control whether the Protocol Fee is charged, similar to the mechanism used in Uniswap. This switch will be controlled by Governance and should be turned off at the beginning of the mainnet deployment. It will be turned on through the Governance process at a later stage.

Objectives

Acceptance Criteria

Ramarti commented 2 months ago

There are several places this fee can be set

For royalty related payments: Fee will be a % of whatever ERC20 is used in payment

For registration fee of any asset, commercial or not, we need to define

kingster-will commented 3 weeks ago

Royalty fee switch added in PR #243