storyprotocol / protocol-periphery-v1

Periphery contract for story protocol, mainnet repo
MIT License
28 stars 20 forks source link

Add Public Minting Support to Periphery Contracts #58

Closed sebsadface closed 1 month ago

sebsadface commented 1 month ago

Description and Context

Currently, SPGNFT supports public minting as introduced in PR #16. However, this feature is not exposed in the periphery contracts. The periphery functions still enforce the onlyCallerWithMinterRole modifier, even though the SPGNFT contract supports public minting.

Suggested Solution

Modify (and rename) the onlyCallerWithMinterRole modifier to check for the isPublicMinting flag. If the flag is enabled, bypass the minter role check to allow public minting.

Definition of Done