Hi,
In parse_dtmf_request_data(), the following condition is there to copy dtmf characters.
if (d->dtmf_length < sizeof(d->dtmf_char)) {
memcpy(d->dtmf_char, p, d->dtmf_length);
}
In above code snippet "sizeof(d->dtmf_char)" is always 7. As per SCTE-35 standard d->dtmf_length can have value 7. In this case the above condition will fail and will not copy dtmf characters to the destination array.
So the condition check has to be modified with "<=" instead of "<". Please check and let me know your view on this.
stoth68000
commented
5 years ago
Hi, In parse_dtmf_request_data(), the following condition is there to copy dtmf characters.
In above code snippet "sizeof(d->dtmf_char)" is always 7. As per SCTE-35 standard d->dtmf_length can have value 7. In this case the above condition will fail and will not copy dtmf characters to the destination array. So the condition check has to be modified with "<=" instead of "<". Please check and let me know your view on this.