stotko / stdgpu

stdgpu: Efficient STL-like Data Structures on the GPU
https://stotko.github.io/stdgpu/
Apache License 2.0
1.16k stars 83 forks source link

examples,src,test: Fix various clang-tidy warnings #328

Closed stotko closed 2 years ago

stotko commented 2 years ago

The recent upgrade of the CI from Ubuntu 20.04 to 22.04 also resulted in having clang-tidy 14 in place which includes more checks than previous versions. Furthermore, more warnings have been enabled (in #327) such that the list of globally suppressed warnings grew over time. Fix various of these warnings and enable them to increase the code quality.

codecov[bot] commented 2 years ago

Codecov Report

Base: 97.14% // Head: 97.14% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (c02dacc) compared to base (93130c4). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #328 +/- ## ========================================== - Coverage 97.14% 97.14% -0.01% ========================================== Files 32 32 Lines 2347 2346 -1 ========================================== - Hits 2280 2279 -1 Misses 67 67 ``` | [Impacted Files](https://codecov.io/gh/stotko/stdgpu/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Stotko) | Coverage Δ | | |---|---|---| | [src/stdgpu/bitset.cuh](https://codecov.io/gh/stotko/stdgpu/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Stotko#diff-c3JjL3N0ZGdwdS9iaXRzZXQuY3Vo) | `100.00% <ø> (ø)` | | | [src/stdgpu/impl/iterator\_detail.h](https://codecov.io/gh/stotko/stdgpu/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Stotko#diff-c3JjL3N0ZGdwdS9pbXBsL2l0ZXJhdG9yX2RldGFpbC5o) | `94.93% <ø> (ø)` | | | [src/stdgpu/impl/memory.cpp](https://codecov.io/gh/stotko/stdgpu/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Stotko#diff-c3JjL3N0ZGdwdS9pbXBsL21lbW9yeS5jcHA=) | `94.59% <ø> (-0.08%)` | :arrow_down: | | [src/stdgpu/impl/unordered\_base.cuh](https://codecov.io/gh/stotko/stdgpu/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Stotko#diff-c3JjL3N0ZGdwdS9pbXBsL3Vub3JkZXJlZF9iYXNlLmN1aA==) | `100.00% <ø> (ø)` | | | [src/stdgpu/impl/unordered\_base\_detail.cuh](https://codecov.io/gh/stotko/stdgpu/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Stotko#diff-c3JjL3N0ZGdwdS9pbXBsL3Vub3JkZXJlZF9iYXNlX2RldGFpbC5jdWg=) | `96.00% <ø> (ø)` | | | [src/stdgpu/openmp/impl/atomic\_detail.h](https://codecov.io/gh/stotko/stdgpu/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Stotko#diff-c3JjL3N0ZGdwdS9vcGVubXAvaW1wbC9hdG9taWNfZGV0YWlsLmg=) | `100.00% <ø> (ø)` | | | [src/stdgpu/openmp/impl/device.cpp](https://codecov.io/gh/stotko/stdgpu/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Stotko#diff-c3JjL3N0ZGdwdS9vcGVubXAvaW1wbC9kZXZpY2UuY3Bw) | `100.00% <ø> (ø)` | | | [src/stdgpu/openmp/impl/memory.cpp](https://codecov.io/gh/stotko/stdgpu/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Stotko#diff-c3JjL3N0ZGdwdS9vcGVubXAvaW1wbC9tZW1vcnkuY3Bw) | `65.21% <ø> (ø)` | | | [src/stdgpu/unordered\_map.cuh](https://codecov.io/gh/stotko/stdgpu/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Stotko#diff-c3JjL3N0ZGdwdS91bm9yZGVyZWRfbWFwLmN1aA==) | `100.00% <ø> (ø)` | | | [src/stdgpu/unordered\_set.cuh](https://codecov.io/gh/stotko/stdgpu/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Stotko#diff-c3JjL3N0ZGdwdS91bm9yZGVyZWRfc2V0LmN1aA==) | `100.00% <ø> (ø)` | | | ... and [6 more](https://codecov.io/gh/stotko/stdgpu/pull/328/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Stotko) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Stotko). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Stotko)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.