stotko / stdgpu

stdgpu: Efficient STL-like Data Structures on the GPU
https://stotko.github.io/stdgpu/
Apache License 2.0
1.16k stars 83 forks source link

memory: Fix missing-return warning in to_address with NVCC #336

Closed stotko closed 2 years ago

stotko commented 2 years ago

The simplification of the implementation of to_address in #332 resulted in a missing-return warning with NVCC for older CUDA versions. This compiler bug has been fixed in newer version, potentially in CUDA 11.5+. Revert to the old pre-C++17 implementation but keep the new code commented for future usage when the requirements will be increased. Furthermore, clean up some namespace qualifications to improve the readability.

codecov[bot] commented 2 years ago

Codecov Report

Base: 97.14% // Head: 97.14% // No change to project coverage :thumbsup:

Coverage data is based on head (ec21711) compared to base (ce7281d). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #336 +/- ## ======================================= Coverage 97.14% 97.14% ======================================= Files 32 32 Lines 2346 2346 ======================================= Hits 2279 2279 Misses 67 67 ``` | [Impacted Files](https://codecov.io/gh/stotko/stdgpu/pull/336?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Stotko) | Coverage Δ | | |---|---|---| | [src/stdgpu/impl/memory\_detail.h](https://codecov.io/gh/stotko/stdgpu/pull/336/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Stotko#diff-c3JjL3N0ZGdwdS9pbXBsL21lbW9yeV9kZXRhaWwuaA==) | `99.03% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Stotko). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Stotko)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.