stotko / stdgpu

stdgpu: Efficient STL-like Data Structures on the GPU
https://stotko.github.io/stdgpu/
Apache License 2.0
1.15k stars 81 forks source link

General: Remove unused cmath header #353

Closed stotko closed 1 year ago

stotko commented 1 year ago

The cmath header has been part of stdgpu since its initial release. However, it only comprises the implementation abs for float values. Since the the this functionality is not required for the major parts of the library and the usability is limited, remove the header along with the tests.

If some functionality of cmath from the C++ standard becomes relevant in the future, the header can be reintroduced.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.01 :warning:

Comparison is base (8edb9e4) 97.14% compared to head (c734cd0) 97.14%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #353 +/- ## ========================================== - Coverage 97.14% 97.14% -0.01% ========================================== Files 32 31 -1 Lines 2346 2344 -2 ========================================== - Hits 2279 2277 -2 Misses 67 67 ``` [see 1 file with indirect coverage changes](https://codecov.io/gh/stotko/stdgpu/pull/353/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Stotko) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Stotko). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Stotko)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.