stotko / stdgpu

stdgpu: Efficient STL-like Data Structures on the GPU
https://stotko.github.io/stdgpu/
Apache License 2.0
1.15k stars 81 forks source link

cmake: Improve thrust system path logic #355

Closed stotko closed 1 year ago

stotko commented 1 year ago

In #263, an additional path hint has been added to better detect thrust on various systems. However, this may still fail in more general environments where the CUDA toolkit is locally installed in a non-system directory, e.g. in Conda installations. Thus, rely on the results of CMake's FindCUDAToolkit.cmake module to obtain a consistent path hint. Furthermore, factor this logic out into a separate CMake function to unify the search logic with the existing one in HIP backend.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (1f6e52b) 97.14% compared to head (72fa659) 97.14%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #355 +/- ## ======================================= Coverage 97.14% 97.14% ======================================= Files 31 31 Lines 2344 2344 ======================================= Hits 2277 2277 Misses 67 67 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Stotko). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Stotko)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.