stotko / stdgpu

stdgpu: Efficient STL-like Data Structures on the GPU
https://stotko.github.io/stdgpu/
Apache License 2.0
1.15k stars 81 forks source link

memory: Remove allocator_traits specialization detection #376

Closed stotko closed 1 year ago

stotko commented 1 year ago

In order to safely skip calling destroy on trivial types, the allocator_traits class is also checked for specializations where the behavior of the construct and destroy functions could potentially be changed in an arbitrary and unpredictable way. As of C++23, such specializations have been forbidden. Thus, remove the check to reduce the maintenance burden.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.08 :tada:

Comparison is base (64f4fe2) 97.32% compared to head (dd26fd6) 97.40%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #376 +/- ## ========================================== + Coverage 97.32% 97.40% +0.08% ========================================== Files 31 31 Lines 2505 2547 +42 ========================================== + Hits 2438 2481 +43 + Misses 67 66 -1 ``` | [Impacted Files](https://app.codecov.io/gh/stotko/stdgpu/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Stotko) | Coverage Δ | | |---|---|---| | [src/stdgpu/impl/deque\_detail.cuh](https://app.codecov.io/gh/stotko/stdgpu/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Stotko#diff-c3JjL3N0ZGdwdS9pbXBsL2RlcXVlX2RldGFpbC5jdWg=) | `94.09% <100.00%> (ø)` | | | [src/stdgpu/impl/memory\_detail.h](https://app.codecov.io/gh/stotko/stdgpu/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Stotko#diff-c3JjL3N0ZGdwdS9pbXBsL21lbW9yeV9kZXRhaWwuaA==) | `99.00% <100.00%> (-0.01%)` | :arrow_down: | | [src/stdgpu/impl/unordered\_base\_detail.cuh](https://app.codecov.io/gh/stotko/stdgpu/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Stotko#diff-c3JjL3N0ZGdwdS9pbXBsL3Vub3JkZXJlZF9iYXNlX2RldGFpbC5jdWg=) | `96.51% <100.00%> (+0.39%)` | :arrow_up: | | [src/stdgpu/impl/vector\_detail.cuh](https://app.codecov.io/gh/stotko/stdgpu/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Stotko#diff-c3JjL3N0ZGdwdS9pbXBsL3ZlY3Rvcl9kZXRhaWwuY3Vo) | `94.59% <100.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/stotko/stdgpu/pull/376/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Patrick+Stotko)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.