search

stouset / twitter_bootstrap_form_for

A Rails FormBuilder DSL for generating Twitter Bootstrap forms
https://github.com/stouset/twitter_bootstrap_form_for
MIT License
410 stars 107 forks source link

bootstrap-2.0 branch - controls.radio_button label #59

Open kylebolstad opened 12 years ago

kylebolstad commented 12 years ago

It looks like the "for" attribute in the "label" tag is the same value for all radio buttons in a control-group. As a result, clicking the label doesn't select the corresponding radio button.

evgenyneu commented 12 years ago

I noticed it as well. The result for the user is when you click a label it does not change to the corresponding radio button. The following is the suggested html taken from Twitter Bootstrap. Notice that labels have no for attributes. Can we achieve that?

<label class="radio">
  <input type="radio" name="optionsRadios" id="optionsRadios1" value="option1" checked>
  Option one is this and that—be sure to include why it's great
</label>
<label class="radio">
  <input type="radio" name="optionsRadios" id="optionsRadios2" value="option2">
  Option two can be something else and selecting it will deselect option one
</label>