stovmascript / ionic-version

:1234: Version your Ionic app in a `npm version` fashion.
MIT License
3 stars 3 forks source link

Doesn't work on Ionic 5 - Missing app-scripts package #58

Open Squix opened 4 years ago

Squix commented 4 years ago

The build process seems to have changed since this script. Ionic-app-scripts aren't anymore present in the package.json and adding their package doesn't solve anything.

package.json :

" ... scripts": { "ng": "ng", "start": "ng serve", "build": "ng build", "test": "ng test", "lint": "ng lint", "e2e": "ng e2e" } ...

Error message when launching ionic-version, both from CLI and postversion npm script :

[IV] Is this the right folder? Cannot find module '@ionic/app-scripts' in C:\Users\Squix\appProject [IV] Pass the project path as an argument, see --help for usage. Usage: cli [options] [projectPath] ...

I'm obviously running it in an app folder with the package.json, moreover, it doesn't work either when giving it the path of the app

carlosen14 commented 4 years ago

throws this, looks like is looking for @ionic/app-scripts lib.

[IV] Cannot find module '@ionic/app-scripts'
Require stack:
- /home/carlos/test/ecommerce-mobile/noop.js
[IV] Is this the right folder? Looks like there isn't a package.json here.
[IV] Pass the project path as an argument, see --help for usage.
carlosen14 commented 4 years ago

installed @ionic/app-scripts on proyect, now when i run ionic-version, this copy the package.json version to config.xml version. Both ended up with the same version.

HugoGresse commented 3 years ago

Any news on this? maybe we need to create a fork?

Squix commented 3 years ago

I created an in-house node script to edit Android gradle file and IOS Plist. Will be interested to contribute @HugoGresse

thiras commented 3 years ago

The issue still exists